Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/justin.pumford/update tools #28

Open
wants to merge 94 commits into
base: master
Choose a base branch
from

Conversation

jpumford
Copy link
Contributor

Enjoy!

andrewjensen and others added 30 commits May 25, 2016 11:42
The instructions included after the setup script is run were not in sync with the documentation.
Change to `npm run upload`
* added Prerequisites
* fixed lint doc
- Correct `setup` script
- Add link to component-based-development
There is now an endpoint to get data with a POST rather than a GET
with query parameters. This commit allows us to use this endpoint
while developing locally.

I am having trouble getting the POST endpoint to work correctly and
consistently, so I don't want to merge this yet until that is
resolved.
Fixed all eslint errors

Changed request from data to body property
All results of mobile in comments, file names, file references updated
to refer to view as responsive
When an app has two distinct designs the switcher.js gets called. Now
the dev decides what design will be loaded for tablets.
No longer depends on a timeout which could cause race conditions. Use
requestAnimationFrame for more consistent behavior and better
performance.
Fixed all devices return correct build files. Updated media queries to
cover full range of sizes and devices.
jpumford and others added 17 commits September 19, 2016 17:43
style(constants): add extra line at end to satisfy EOL rule
fix(babel): switch babel preset to es2015
DAS-4335: fix(switcher): add template with viewport meta tag
feat(server.es6.js): add support for devtokens
feat: add strict angular dependency injection
perf(webpack.config): enable caching of both sourcemaps and modules
feat(package.json): added simple support to keep package.json up to date
…ronments

the `cp -r` command worked inconsistently between osx and linux. cp -r on osx will copy the contents
of the first argument (the source directory) into the output directory. On linux, cp -r would copy
the *source folder* into the destination folder. A blob is used to copy all (except dotfiles) from
the domo folder to the dist folder
fix(package.json): fix `cp -r` command to work properly on linux environments
feat(webpack.config,eslintrc): add APP_NAME and VERSION to constants
@jpumford
Copy link
Contributor Author

@bmbarker90 it's just an update-tools

Copy link
Contributor

@sldavidson sldavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an error when trying to run
ERROR in ./~/angular-material/index.js Module not found: Error: Cannot resolve module 'angular-animate' in .../advanced-sample-app/node_modules/angular-material @ ./~/angular-material/index.js 5:0-26

I think it just needs to be listed as an external.

Also there is a lot of Redux stubbed out code that isn't being used in this project that we could clean out.

@jpumford
Copy link
Contributor Author

@sldavidson Yeah, I thought about the redux stubs! I left them because I was worried removing them would make other update-tools pretty complicated, especially if we modify those stubs on generator. It's up to you; I can remove the stubs if you'd like.

@jpumford
Copy link
Contributor Author

@sldavidson As far as angular-animate goes, should it be added as an external to starter-kit as well, considering it is external? We could run into the same issue

Justin Pumford added 2 commits April 12, 2017 10:43
…encies

Using a newer version of angular-aria with angular-material led to an issue documented here:
angular/material#10475
angular-animate was "missing" as a module since it is loaded from a cdn. This adds it as a webpack
external so angular-material can load the module
@jpumford
Copy link
Contributor Author

@sldavidson alright, that's been updated! Let me know what your thoughts are about the redux stubs.

@sldavidson
Copy link
Contributor

It might confuse people who are looking at the code and see stubbed out code.

@sldavidson sldavidson mentioned this pull request Apr 12, 2017
Copy link
Contributor

@sldavidson sldavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looking over the changes, it appears the cross-evn from #27 and DomoApps/starter-kit#68 is not getting pulled in.

@jpumford
Copy link
Contributor Author

@sldavidson yes, that's because I made the PR when Jake was having issues with cross-env. If you'd like I can add that to this one as well, I just wanted to split up as much as possible (though this PR is still a mess... update-tools is going to have to change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants